feat(cloudnative-pg): add annotations to all CRDs #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmj
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
bot
added
size:M
We want to be able to pass annotations to all CustomResourceDefinitions.
This is helpful in that it allows passing an annotation to ArgoCD to
enable ServerSideApply:
```
crds:
annotations:
argocd.argoproj.io/sync-options: ServerSideApply=true
```
Fixes cloudnative-pg#656
Signed-off-by: Johannes Meixner <[email protected]>
zied-jt
approved these changes
Sep 5, 2025
|
What is missing for this to be merged? |
Sorry for bringing this up again, but why is this simple PR still open? What is missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to pass annotations to all CustomResourceDefinitions.
This is helpful in that it allows passing an annotation to ArgoCD to enable ServerSideApply:
Fixes #656